Commit Graph

25301 Commits

Author SHA1 Message Date
Salman Ahmed
dccd37d92d Remove iPhone/iPhoneSimulator platform configurations 2024-08-08 12:53:33 +03:00
Dean Herbert
4658a3fedb Merge pull request #6350 from smoogipoo/fix-whitepixel-texture-wrap
Fix texture wrapping not updating on consecutive WhitePixel use
2024-08-08 15:42:12 +09:00
Dan Balasescu
0750044927 Fix another test
The assertions are kinda dodgy in this case, but it is what it is. This
is the only assertion in `Renderer`, so it's maybe even a matter for the
implementations to resolve by not doing draw-thread-requiring calls in
the ctor.
2024-08-08 14:32:25 +09:00
Dan Balasescu
3f06897683 Fix dodgy implementations now that DummyRenderer is an actual renderer 2024-08-08 14:16:36 +09:00
Dan Balasescu
ab6d9056c3 Restore helper method to create dummy texture
This is actually used in osu! tests, and I'd rather this PR be
non-breaking.
2024-08-08 13:52:21 +09:00
Dan Balasescu
19775809b7 Fix class name + update method name 2024-08-08 13:48:56 +09:00
Dan Balasescu
3a6187580a Fix texture wrapping not updating on consecutive WhitePixel use 2024-08-08 13:46:05 +09:00
Dan Balasescu
aeffd4e070 Add failing test 2024-08-08 13:44:57 +09:00
Dan Balasescu
22b4405edb Make DummyRenderer inherit Renderer instead of interface
Allows for testing actual implementation.
2024-08-08 13:44:52 +09:00
Dean Herbert
ad19871261 Merge pull request #6349 from smoogipoo/sdl3-bindings-update
Update SDL3 bindings
2024-08-08 01:39:30 +09:00
Dean Herbert
622f214ff3 Update iOS method calls 2024-08-08 01:25:15 +09:00
Dan Balasescu
b237eaec24 Fix macOS window class 2024-08-07 23:33:20 +09:00
Dan Balasescu
2873f7f1d5 Update package 2024-08-07 23:24:11 +09:00
hwsmm
4b18d9d661 Apply a change for SDL3 bindings update 2024-08-06 20:06:46 +09:00
hwsmm
7e8b45cd7a Apply a change for SDL3 bindings update 2024-08-05 22:48:24 +09:00
hwsmm
4652fb96fd Merge master 2024-08-05 19:41:42 +09:00
Dean Herbert
af4e54d7af Merge pull request #6348 from smoogipoo/bindablelist-gc-reduction
Remove HashSet allocations during BindableList methods
2024-08-05 17:23:10 +09:00
Dan Balasescu
af8bb5d3d8 Remove static class 2024-08-05 17:09:16 +09:00
Dan Balasescu
c6df1f38a7 Remove HashSet allocations during BindableList methods 2024-08-05 14:15:45 +09:00
hwsmm
a4c780e2f5 Merge master 2024-08-03 19:54:59 +09:00
Dan Balasescu
4779e1b82e Merge pull request #6347 from frenzibyte/fix-ptim-not-always-releasing
Fix `PassThroughInputManager` not always releasing input
2024-08-02 18:50:47 +09:00
Salman Ahmed
1a71e0cddf Fix PassThroughInputManager not always syncing input releases 2024-08-02 10:11:02 +03:00
Salman Ahmed
86802b1855 Add failing test case 2024-08-02 10:11:02 +03:00
hwsmm
84d32375cc Apply a change for SDL3 bindings update 2024-07-28 14:40:37 +09:00
hwsmm
149ffa88e3 Merge master 2024-07-28 13:37:42 +09:00
Dan Balasescu
2772619b5a Merge pull request #6344 from smoogipoo/fix-csproj
Fix line endings in csproj
2024-07-25 13:57:35 +09:00
Dan Balasescu
7f927f909d Fix line endings in csproj 2024-07-25 10:24:06 +09:00
Dean Herbert
1eb26565dc Merge pull request #6343 from ppy/dependabot/nuget/osu.Framework/SixLabors.ImageSharp-3.1.5
Bump SixLabors.ImageSharp from 3.1.4 to 3.1.5 in /osu.Framework
2024-07-23 04:38:37 +09:00
dependabot[bot]
49d5a1968c Bump SixLabors.ImageSharp from 3.1.4 to 3.1.5 in /osu.Framework
Bumps [SixLabors.ImageSharp](https://github.com/SixLabors/ImageSharp) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/SixLabors/ImageSharp/releases)
- [Commits](https://github.com/SixLabors/ImageSharp/compare/v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: SixLabors.ImageSharp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-22 17:44:50 +00:00
hwsmm
5f2813e70c Apply a change for SDL3 bindings update 2024-07-20 17:13:43 +09:00
hwsmm
33fd9d9843 Merge branch 'master' into sdl3-bindings-update 2024-07-20 16:54:34 +09:00
Dean Herbert
891e4ff23e Merge pull request #6340 from frenzibyte/revert-some-ptim-changes
Keep `PassThroughInputManager` in input queue even while parent input is disabled
2024-07-20 13:35:59 +09:00
Dean Herbert
d58dd3c03e Merge pull request #6338 from frenzibyte/disable-trailing-comma
Disable multi-line trailing comma inspections entirely
2024-07-20 00:14:25 +09:00
Salman Ahmed
b9a47a057e Keep PassThroughInputManager in input queue even while parent input is disabled 2024-07-19 15:18:00 +03:00
Salman Ahmed
49974dc832 Add failing test case 2024-07-19 15:16:30 +03:00
Salman Ahmed
f5664483ea Disable multi-line trailing comma inspections entirely 2024-07-19 14:40:50 +03:00
Salman Ahmed
23423131bd Merge pull request #6337 from Nierius/b/vscode-samplegame-config
Fix SampleGame prelaunch tasks
2024-07-19 06:50:34 +03:00
Nierius
0f3855339d Fix SampleGame prelaunch tasks 2024-07-18 21:06:04 +03:00
Dean Herbert
ff053db329 Merge pull request #6335 from bdach/fix-popover-seizure
Fix popovers one-frame-twitching in specific circumstances
2024-07-18 13:12:24 +09:00
Dean Herbert
7465990592 Merge pull request #6334 from smoogipoo/macos-ci-test-output
Reduce macOS CI test output
2024-07-17 17:50:08 +09:00
Dean Herbert
4db6727d74 Merge pull request #6314 from hwsmm/sdl3-bindings-update
Update SDL3-CS
2024-07-17 17:49:14 +09:00
Bartłomiej Dach
7caa069c15 Fix popovers one-frame-twitching in specific circumstances
Closes https://github.com/ppy/osu/issues/28865.

The issue is caused specifically by the "arrow" part of the popover.
The feedback loop involved in this is as follows:

- A popover is added to the scene graph. The automatic anchor selection
  logic chooses an anchor and a position for it. For the arrow part
  specifically, this is compounded with a counteracting adjustment
  that ensures that the popover arrow continues to point at its target
  drawable:

    691d8671be/osu.Framework/Graphics/Cursor/PopoverContainer.cs (L143-L147)

- The base `Popover` class uses autosize on both axes of its
  `BoundingBoxContainer`, whose bounds are used to calculate the best
  anchor:

    691d8671be/osu.Framework/Graphics/UserInterface/Popover.cs (L21)

  The arrow is under the bounding box container. Adjusting a drawable's
  position affects autosize by way of changing
  `RequiredParentSizeToFit`, which means that if the drawable's target
  is significantly off screen, the calculated autosize of the container
  rapidly balloons.

- If the popover size increases enough, then no anchors will be
  considered fitting (because to the automatic layouting logic, it looks
  like the popover won't fit in *any* direction). Thus, the popover's
  anchor is changed from whatever it was on the previous frame to
  `Centre`, and the arrow's position is reset to zero.

- The resetting of the arrow position to zero brings us back to
  the situation from the first point, completing the feedback cycle.

To counteract this, exclude the popover arrow from participating in
autosize calculations.
2024-07-17 10:35:45 +02:00
Bartłomiej Dach
fb20c460a9 Add failing visual test case for popover twitching 2024-07-17 10:25:02 +02:00
Bartłomiej Dach
4367d01a1b Fix popovers getting masked away even if content still intersects masking bounds 2024-07-17 10:24:50 +02:00
Dan Balasescu
90b1528333 Suppress NUnit console output 2024-07-17 17:19:38 +09:00
Dan Balasescu
46775892ba Remove custom NUnit test settings 2024-07-17 17:18:48 +09:00
Dan Balasescu
18434ddc39 Update SDL3 package 2024-07-17 16:48:51 +09:00
Dean Herbert
691d8671be Merge pull request #6327 from smoogipoo/headless-thread-rate-matching
Make time move along at the same rate in all threads during headless execution
2024-07-16 17:06:37 +09:00
Dean Herbert
2ddb18c97c Merge pull request #6331 from smoogipoo/fix-fbo-rt-leak
Fix deferred FBO depth target texture leak
2024-07-16 17:01:27 +09:00
Dan Balasescu
e0739222e9 Fix deferred FBO depth target texture leak 2024-07-16 15:00:33 +09:00