aecw/osu-framework
1
0
Fork 0
mirror of https://github.com/SK-la/osu-framework.git synced 2026-03-13 11:20:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some issues rider did not raise

Browse Source
This commit is contained in:
Dean Herbert
2022-11-16 19:42:28 +09:00
parent 63405204eb
commit e9f08ad887
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Framework.Tests/Containers/ContainerEnumerableTest.cs
View File

@@ -46,7 +46,7 @@ namespace osu.Framework.Tests.Containers
{
var unused = new AudioContainer
{
Children = (IReadOnlyList<Drawable>)Activator.CreateInstance(containerType)
Children = (IReadOnlyList<Drawable>)Activator.CreateInstance(containerType)!
};
});
@@ -54,7 +54,7 @@ namespace osu.Framework.Tests.Containers
{
var unused = new AudioContainer();
unused.AddRange((IEnumerable<Drawable>)Activator.CreateInstance(containerType));
unused.AddRange((IEnumerable<Drawable>)Activator.CreateInstance(containerType)!);
});
}
}

5
osu.Framework.Tests/Visual/Graphics/TestSceneStencil.cs
View File

@@ -2,6 +2,7 @@
// See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic;
using System.Diagnostics;
using osu.Framework.Allocation;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
@@ -94,6 +95,8 @@ namespace osu.Framework.Tests.Visual.Graphics
// No depth testing.
renderer.PushDepthInfo(new DepthInfo(false));
Debug.Assert(Children != null);
drawStencil(renderer, Children[1]);
drawBackground(renderer, Children[0]);
@@ -141,7 +144,7 @@ namespace osu.Framework.Tests.Visual.Graphics
renderer.PopStencilInfo();
}
public List<DrawNode> Children { get; set; } = new List<DrawNode>();
public List<DrawNode>? Children { get; set; } = new List<DrawNode>();
public bool AddChildDrawNodes => true;
}

2
osu.Framework/Graphics/ICompositeDrawNode.cs
View File

@@ -15,7 +15,7 @@ namespace osu.Framework.Graphics
/// <summary>
/// The child <see cref="DrawNode"/>s to draw.
/// </summary>
List<DrawNode> Children { get; set; }
List<DrawNode>? Children { get; set; }
/// <summary>
/// Whether <see cref="Children"/> should be updated by the parenting <see cref="CompositeDrawable"/>.

2
osu.Framework/Graphics/IDrawable.cs
View File

@@ -42,7 +42,7 @@ namespace osu.Framework.Graphics
/// <summary>
/// The parent of this drawable in the scene graph.
/// </summary>
CompositeDrawable Parent { get; }
CompositeDrawable? Parent { get; }
/// <summary>
/// Whether this drawable is present for any sort of user-interaction.