Make edits based on reviews

This commit is contained in:
Denis Titovets
2025-08-19 19:02:13 +03:00
parent 5dc44fbdf9
commit e183e6bb88
9 changed files with 51 additions and 37 deletions

View File

@@ -36,7 +36,7 @@ namespace osu.Game.Rulesets.Osu.UI
};
public ReplayAnalysisSettings(OsuRulesetConfigManager config)
: base(PlayerLoaderStrings.AnalysisSettingsTitle)
: base(PlayerSettingsStrings.AnalysisSettingsTitle)
{
this.config = config;
}

View File

@@ -194,6 +194,11 @@ namespace osu.Game.Localisation
/// </summary>
public static LocalisableString Details => new TranslatableString(getKey(@"details"), @"Details...");
/// <summary>
/// "Creator"
/// </summary>
public static LocalisableString Creator => new TranslatableString(getKey(@"creator"), @"Creator");
private static string getKey(string key) => $@"{prefix}:{key}";
}
}

View File

@@ -43,36 +43,6 @@ Leaderboards may be reset.");
public static LocalisableString QualifiedBeatmapDisclaimerContent => new TranslatableString(getKey(@"qualified_beatmap_disclaimer_content"), @"No performance points will be awarded.
Leaderboards will be reset when the beatmap is ranked.");
/// <summary>
/// "Mapper"
/// </summary>
public static LocalisableString ShowInfoMapper => new TranslatableString(getKey(@"show_info_mapper"), @"Mapper");
/// <summary>
/// "Playback"
/// </summary>
public static LocalisableString PlaybackTitle => new TranslatableString(getKey(@"playback_title"), @"Playback");
/// <summary>
/// "Visual Settings"
/// </summary>
public static LocalisableString VisualSettingsTitle => new TranslatableString(getKey(@"visual_settings_title"), @"Visual Settings");
/// <summary>
/// "Audio Settings"
/// </summary>
public static LocalisableString AudioSettingsTitle => new TranslatableString(getKey(@"audio_settings_title"), @"Audio Settings");
/// <summary>
/// "Input Settings"
/// </summary>
public static LocalisableString InputSettingsTitle => new TranslatableString(getKey(@"input_settings_title"), @"Input Settings");
/// <summary>
/// "Analysis Settings"
/// </summary>
public static LocalisableString AnalysisSettingsTitle => new TranslatableString(getKey(@"analysis_settings_title"), @"Analysis Settings");
private static string getKey(string key) => $@"{prefix}:{key}";
}
}

View File

@@ -0,0 +1,39 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using osu.Framework.Localisation;
namespace osu.Game.Localisation
{
public class PlayerSettingsStrings
{
private const string prefix = @"osu.Game.Resources.Localisation.PlayerSettings";
/// <summary>
/// "Playback"
/// </summary>
public static LocalisableString PlaybackTitle => new TranslatableString(getKey(@"playback_title"), @"Playback");
/// <summary>
/// "Visual Settings"
/// </summary>
public static LocalisableString VisualSettingsTitle => new TranslatableString(getKey(@"visual_settings_title"), @"Visual Settings");
/// <summary>
/// "Audio Settings"
/// </summary>
public static LocalisableString AudioSettingsTitle => new TranslatableString(getKey(@"audio_settings_title"), @"Audio Settings");
/// <summary>
/// "Input Settings"
/// </summary>
public static LocalisableString InputSettingsTitle => new TranslatableString(getKey(@"input_settings_title"), @"Input Settings");
/// <summary>
/// "Analysis Settings"
/// </summary>
public static LocalisableString AnalysisSettingsTitle => new TranslatableString(getKey(@"analysis_settings_title"), @"Analysis Settings");
private static string getKey(string key) => $@"{prefix}:{key}";
}
}

View File

@@ -15,11 +15,11 @@ using osu.Game.Beatmaps.Drawables;
using osu.Game.Graphics;
using osu.Game.Graphics.Sprites;
using osu.Game.Graphics.UserInterface;
using osu.Game.Localisation;
using osu.Game.Resources.Localisation.Web;
using osu.Game.Rulesets.Mods;
using osu.Game.Screens.Play.HUD;
using osuTK;
using CommonStrings = osu.Game.Localisation.CommonStrings;
namespace osu.Game.Screens.Play
{
@@ -166,7 +166,7 @@ namespace osu.Game.Screens.Play
},
new Drawable[]
{
new MetadataLineLabel(PlayerLoaderStrings.ShowInfoMapper),
new MetadataLineLabel(CommonStrings.Creator),
new MetadataLineInfo(metadata.Author.Username)
}
}

View File

@@ -19,7 +19,7 @@ namespace osu.Game.Screens.Play.PlayerSettings
private readonly PlayerCheckbox beatmapHitsoundsToggle;
public AudioSettings()
: base(PlayerLoaderStrings.AudioSettingsTitle)
: base(PlayerSettingsStrings.AudioSettingsTitle)
{
Children = new Drawable[]
{

View File

@@ -12,7 +12,7 @@ namespace osu.Game.Screens.Play.PlayerSettings
public partial class InputSettings : PlayerSettingsGroup
{
public InputSettings()
: base(PlayerLoaderStrings.InputSettingsTitle)
: base(PlayerSettingsStrings.InputSettingsTitle)
{
}

View File

@@ -41,7 +41,7 @@ namespace osu.Game.Screens.Play.PlayerSettings
private IconButton pausePlay = null!;
public PlaybackSettings()
: base(PlayerLoaderStrings.PlaybackTitle)
: base(PlayerSettingsStrings.PlaybackTitle)
{
}

View File

@@ -18,7 +18,7 @@ namespace osu.Game.Screens.Play.PlayerSettings
private readonly PlayerCheckbox beatmapColorsToggle;
public VisualSettings()
: base(PlayerLoaderStrings.VisualSettingsTitle)
: base(PlayerSettingsStrings.VisualSettingsTitle)
{
Children = new Drawable[]
{