aecw/Ez2Lazer
1
0
Fork 0
mirror of https://github.com/SK-la/Ez2Lazer.git synced 2026-03-13 11:20:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unimplement legacy compatibility method (#36812)

Browse Source 
The spectator server invokes both legacy and non-legacy methods to keep
compatibility with older clients:


fe0dad3245/osu.Server.Spectator/Hubs/Multiplayer/Matchmaking/Queue/MatchmakingQueueBackgroundService.cs (L292-L299)

I thought that it'd be a good idea to implement the legacy method here,
but it turns out to not be such a good idea because it means ranked-play
clients will assume they're receiving a quick play invitation.
This commit is contained in:
Dan Balasescu
2026-03-05 00:31:43 +09:00
committed by GitHub
parent a0ecbd7c87
commit ae032622ac
3 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Online/Matchmaking/IMatchmakingClient.cs
View File

@@ -1,6 +1,7 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using System.Threading.Tasks;
namespace osu.Game.Online.Matchmaking
@@ -26,6 +27,7 @@ namespace osu.Game.Online.Matchmaking
/// <remarks>
/// Provided for compatibility with older clients - can be removed 20260825.
/// </remarks>
[Obsolete]
Task MatchmakingRoomInvited();
/// <summary>

4
osu.Game/Online/Multiplayer/MultiplayerClient.cs
View File

@@ -1085,8 +1085,8 @@ namespace osu.Game.Online.Multiplayer
Task IMatchmakingClient.MatchmakingRoomInvited()
{
// Compatibility with older servers.
return ((IMatchmakingClient)this).MatchmakingRoomInvitedWithParams(new MatchmakingRoomInvitationParams { Type = MatchmakingPoolType.QuickPlay });
// Not implemented (used by older clients).
return Task.CompletedTask;
}
Task IMatchmakingClient.MatchmakingRoomInvitedWithParams(MatchmakingRoomInvitationParams invitation)

1
osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs
View File

@@ -75,7 +75,6 @@ namespace osu.Game.Online.Multiplayer
connection.On(nameof(IMatchmakingClient.MatchmakingQueueJoined), ((IMatchmakingClient)this).MatchmakingQueueJoined);
connection.On(nameof(IMatchmakingClient.MatchmakingQueueLeft), ((IMatchmakingClient)this).MatchmakingQueueLeft);
connection.On(nameof(IMatchmakingClient.MatchmakingRoomInvited), ((IMatchmakingClient)this).MatchmakingRoomInvited);
connection.On<MatchmakingRoomInvitationParams>(nameof(IMatchmakingClient.MatchmakingRoomInvitedWithParams), ((IMatchmakingClient)this).MatchmakingRoomInvitedWithParams);
connection.On<long, string>(nameof(IMatchmakingClient.MatchmakingRoomReady), ((IMatchmakingClient)this).MatchmakingRoomReady);
connection.On<MatchmakingLobbyStatus>(nameof(IMatchmakingClient.MatchmakingLobbyStatusChanged), ((IMatchmakingClient)this).MatchmakingLobbyStatusChanged);